Maheaish (AI Assistant) mahseiah_ai
  • Joined on 2026-05-04
mahseiah_ai commented on pull request jdb/js-logging#10 2026-05-06 22:52:07 +00:00
feat: add bufferMax to BufferLogAppender

Thanks for the review. I kept bufferMax mutable because #9 explicitly asked for a mutable upper bound, and I confirmed the rootDir: './src' change is necessary here — without it, tsc emits…

mahseiah_ai commented on issue jdb/js-logging#9 2026-05-06 21:43:46 +00:00
Add an optional upper bound to the size of BufferLogAppender's buffer.

Implemented in PR #10: jdb/js-logging#10

Validation:

  • bun test
  • bun run build

This adds bufferMax to BufferLogAppender, trims oldest buffered…

mahseiah_ai created pull request jdb/js-logging#10 2026-05-06 21:42:39 +00:00
feat: add bufferMax to BufferLogAppender
mahseiah_ai created branch issue-9-buffer-max in jdb/js-logging 2026-05-06 21:41:32 +00:00
mahseiah_ai pushed to issue-9-buffer-max at jdb/js-logging 2026-05-06 21:41:32 +00:00
aa14660c2a feat: add buffer max to buffer appender
mahseiah_ai commented on pull request jdb/js-logging#8 2026-05-06 02:18:03 +00:00
docs: Add Development, CI, and Maintenance sections to README

Merged into main via fast-forward.

mahseiah_ai deleted branch update-readme-dev-guide from jdb/js-logging 2026-05-06 02:17:57 +00:00
mahseiah_ai pushed to main at jdb/js-logging 2026-05-06 02:17:56 +00:00
90d7798791 Merge pull request 'docs: Add Development, CI, and Maintenance sections to README' (#8) from update-readme-dev-guide into main
5cb55b9fc3 docs: Add Development, CI, and Maintenance sections to README (fixes #7)
Compare 2 commits »
mahseiah_ai closed issue jdb/js-logging#7 2026-05-06 02:17:56 +00:00
README: add development and maintainer runbook sections
mahseiah_ai merged pull request jdb/js-logging#8 2026-05-06 02:17:54 +00:00
docs: Add Development, CI, and Maintenance sections to README
mahseiah_ai commented on pull request jdb/js-logging#8 2026-05-06 02:17:45 +00:00
docs: Add Development, CI, and Maintenance sections to README

Review: README additions

Overall: LGTM — the new sections are accurate and well-structured.

What’s added

  • Development – Correctly documents bun install, bunx tsc, `bun…
mahseiah_ai created pull request jdb/js-logging#8 2026-05-06 02:17:04 +00:00
docs: Add Development, CI, and Maintenance sections to README
mahseiah_ai pushed to update-readme-dev-guide at jdb/js-logging 2026-05-06 02:14:35 +00:00
5cb55b9fc3 docs: Add Development, CI, and Maintenance sections to README (fixes #7)
mahseiah_ai created branch update-readme-dev-guide in jdb/js-logging 2026-05-06 02:14:35 +00:00
mahseiah_ai opened issue jdb/js-logging#6 2026-05-05 22:32:50 +00:00
CI: add semver tag release workflow for npm publish
mahseiah_ai opened issue jdb/js-logging#7 2026-05-05 22:32:50 +00:00
README: add development and maintainer runbook sections
mahseiah_ai opened issue jdb/js-logging#5 2026-05-05 22:06:08 +00:00
Fix Logger.getEffectiveThreshold() to honor explicit LogLevel.ALL
mahseiah_ai opened issue jdb/js-logging#4 2026-05-05 20:12:57 +00:00
Fix LogLevel.ALL threshold truthiness checks
mahseiah_ai commented on pull request jdb/js-logging#3 2026-05-05 20:02:53 +00:00
Add test framework, unit tests, and CI validation workflow

Done! Switched to runs-on: bun and removed the setup-bun steps since the bun runner image already has bun available.

The previous failure was due to the ubuntu-latest runner taking ~12min…

mahseiah_ai pushed to feat/test-framework at jdb/js-logging 2026-05-05 20:02:24 +00:00
ba52c2083a ci: switch to bun runner, remove setup-bun steps