Jonathan Bernard jdb
  • Joined on 2024-08-11
jdb closed pull request jdb/js-logging#10 2026-05-07 12:36:43 +00:00
feat: add bufferMax to BufferLogAppender
jdb commented on pull request jdb/js-logging#10 2026-05-06 22:10:28 +00:00
feat: add bufferMax to BufferLogAppender

Looks like you hit rate limits, can you continue and answer my question above?

jdb commented on pull request jdb/js-logging#10 2026-05-06 21:59:51 +00:00
feat: add bufferMax to BufferLogAppender

What are the performance characteristics of this pattern? Specifically in two cases:

jdb commented on issue jdb/js-logging#9 2026-05-06 20:43:49 +00:00
Add an optional upper bound to the size of BufferLogAppender's buffer.

@mahseiah_ai Can you pick this up and implement it? Let's also bump the minor version number for the package. When the PR is ready I'll review it. Once its approved and we merge, we should tag the…

jdb opened issue jdb/js-logging#9 2026-05-06 20:42:02 +00:00
Add an optional upper bound to the size of BufferLogAppender's buffer.
jdb commented on issue jdb/js-logging#7 2026-05-05 22:42:40 +00:00
README: add development and maintainer runbook sections

Regarding the open questions:

  • We should mention npm publish, but as part of the current manual release process. This process is (in brief):
    • Ensure the library builds and passes test…
jdb deleted branch feat/test-framework from jdb/js-logging 2026-05-05 20:07:15 +00:00
jdb pushed to main at jdb/js-logging 2026-05-05 20:07:14 +00:00
ba52c2083a ci: switch to bun runner, remove setup-bun steps
c38683bf53 ci: replace oven-sh/setup-bun with curl install for Gitea Actions compatibility
c7d618ad92 test: add comprehensive unit tests for all appenders and logger
e76f408f80 ci: add Gitea Actions workflow for test validation
b7e78bbb9d build: add test and test:coverage scripts to package.json
Compare 6 commits »
jdb closed issue jdb/js-logging#2 2026-05-05 20:07:14 +00:00
Add test framework, unit tests, and CI validation workflow
jdb merged pull request jdb/js-logging#3 2026-05-05 20:07:13 +00:00
Add test framework, unit tests, and CI validation workflow
jdb commented on pull request jdb/js-logging#3 2026-05-05 19:59:30 +00:00
Add test framework, unit tests, and CI validation workflow

If we switch to the bun runner as I asked in my previous review comment, we will not need to install bun. It comes packaged in that runner.

jdb suggested changes for jdb/js-logging#3 2026-05-05 19:59:30 +00:00
Add test framework, unit tests, and CI validation workflow
jdb suggested changes for jdb/js-logging#3 2026-05-05 19:42:18 +00:00
Add test framework, unit tests, and CI validation workflow

Overall it looks great! Just one change to the Actions workflow runner config.

jdb commented on pull request jdb/js-logging#3 2026-05-05 19:42:18 +00:00
Add test framework, unit tests, and CI validation workflow

Can we use the bun runner? It is more lightweight than ubuntu-latest and should have everything we need. bun maps to the docker://oven/bun:latest image.

jdb commented on issue jdb/js-logging#2 2026-05-05 18:56:57 +00:00
Add test framework, unit tests, and CI validation workflow

@mahseiah_ai I agree. I think there is only one open questions: Which test runner should we use? This is a very lightweight library. I am leaning towards using bun test to avoid bringing in any…

jdb pushed tag 2.4.0 to jdb/js-logging 2026-05-05 13:54:24 +00:00
jdb deleted branch buffer-log-appender from jdb/js-logging 2026-05-05 13:51:33 +00:00
jdb pushed to main at jdb/js-logging 2026-05-05 13:51:33 +00:00
f9cb676b46 Properly set default thresholds on log appenders.
4dcc4fad25 Add BufferLogAppender
Compare 2 commits »
jdb merged pull request jdb/js-logging#1 2026-05-05 13:51:32 +00:00
Add BufferLogAppender