From 6380c73421f8349b521f905997ea48ec2f04432b Mon Sep 17 00:00:00 2001 From: Jonathan Bernard Date: Sat, 18 May 2019 12:22:30 -0500 Subject: [PATCH] Fix API logger configuration (handle invalid or missing config valeus properly). --- web/src/app.ts | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/web/src/app.ts b/web/src/app.ts index e1c1220..31a2720 100644 --- a/web/src/app.ts +++ b/web/src/app.ts @@ -64,18 +64,10 @@ export default class App extends Vue { this.consoleLogAppender.threshold = commonLevel; } - try { - this.apiLogAppender.batchSize = - parseInt(process.env.VUE_APP_API_LOG_BATCH_SIZE, 10); - } catch { - this.apiLogAppender.batchSize = 5; - } + const batchSize = parseInt(process.env.VUE_APP_API_LOG_BATCH_SIZE, 10); + if (!isNaN(batchSize)) { this.apiLogAppender.batchSize = Math.max(batchSize, 1); } - try { - this.apiLogAppender.minimumTimePassedInSec - = parseInt(process.env.VUE_APP_API_LOG_MIN_TIME_PASSED_IN_SEC, 10); - } catch { - this.apiLogAppender.minimumTimePassedInSec = 5; - } + const minTimeInSec = parseInt(process.env.VUE_APP_API_LOG_MIN_TIME_PASSED_IN_SEC, 10); + if (!isNaN(minTimeInSec)) { this.apiLogAppender.minimumTimePassedInSec = Math.max(minTimeInSec, 1); } } }