Make known Nim allocator race scenarios opt-in

Skip factory-state and allocator by default with explicit skip messages. Preserve both scenarios and enable them with NSL_TEST_RUNTIME_ALLOCATOR=1. Document the deferred runtime issue and remaining validation limits.

Validation: nimble test passes 32 unit tests, 29 regression tests, and 11 sanitizer scenarios, with two skips. Opt-in execution still reports both known allocator failures.

namespaced_logging.nimble

@@ -43,7 +43,7 @@ proc runThreadSafetyTests() =
     raise newException(OSError, "Writer lifecycle test compilation produced no executable")
   exec "bash tests/run_tsan.sh tests/bin/thread_safety tests/bin/writer_lifecycle"
 
-task test, "Run all tests, including ThreadSanitizer, and report all failing suites.":
+task test, "Run all enabled tests, including ThreadSanitizer, and report all failing suites.":
   var failedSuites: seq[string] = @[]
   template runSuite(name: string, action: untyped) =
     echo "Running test suite: ", name

tests/README.md

@@ -1,16 +1,32 @@
 # Regression tests
 
-These tests assert the intended behavior. Known bugs are ordinary failures,
+These tests assert the intended behavior. Enabled tests treat bugs as ordinary
-not expected failures: the tasks should become green as the defects are fixed.
+failures. Two scenarios that expose a known Nim allocator race are temporarily
+disabled by default; they remain available for explicit runs as described below.
 
 Run from the repository root:
 
 | Command | Coverage |
 | --- | --- |
-| `nimble test` | All unit, regression, and ThreadSanitizer tests under ORC with threads enabled |
+| `nimble test` | All enabled unit, regression, and ThreadSanitizer tests under ORC with threads enabled |
 | `nimble testUnit` | Embedded unit tests, including writer submission/shutdown coordination |
 | `nimble testRegression` | Custom-state/formatter ownership, handle lifetime, configuration freshness, refresh failure recovery, appender-state cleanup, and writer shutdown |
-| `nimble testThreadSafety` | Separate ThreadSanitizer processes for service ownership, last-owner teardown, reconfiguration, shared state, factory state, formatter closures, collector snapshots, timestamps, the Nim allocator, and writer lifecycle, plus an independent-service control |
+| `nimble testThreadSafety` | Separate ThreadSanitizer processes for service ownership, last-owner teardown, reconfiguration, shared state, formatter closures, collector snapshots, timestamps, and writer lifecycle, plus an independent-service control; factory-state and allocator scenarios are opt-in |
+
+`factory-state` and `allocator` are reported as **SKIP** in normal runs because
+they expose the default-allocator race in Nim 2.2.10. Resolving that runtime
+issue is deferred. Their implementations and assertions remain intact, and
+their test code is still compiled. To enable both scenarios:
+
+```sh
+NSL_TEST_RUNTIME_ALLOCATOR=1 nimble testThreadSafety
+# Or include them in the full run:
+NSL_TEST_RUNTIME_ALLOCATOR=1 nimble test
+```
+
+When enabled, their failures make the command fail normally. Skipping these
+scenarios does not resolve the runtime limitation or establish that factory
+state is fully validated under the default allocator.
 
 `nimble test` attempts every suite even if an earlier suite fails to compile or
 run, summarizes the failing suites, and exits unsuccessfully if any suite fails.
@@ -66,9 +82,9 @@ alongside thread-local closure allocations. On Nim 2.2.10 it reproduces a report
 in `system/alloc.nim`'s `compensateCounters` / shared-free-list path. The same
 runtime report can occur in `factory-state` and other allocation-heavy cases.
 The ten ownership scenarios passed debug and release diagnostic builds with
-`-d:useMalloc`;
+`-d:useMalloc`. Normal runs retain the default allocator and skip the two
-`nimble test` deliberately retains the default allocator and exposes these
+scenarios above. Sanitizer reports in any enabled scenario still fail the run;
-reports rather than suppressing them.
+there are no sanitizer suppressions.
 
 The original custom-state and formatter scenarios retain parent owners until all
 workers join. They only read application data; their concurrent writes are the
@@ -119,8 +135,8 @@ The suite provides targeted regressions; it does not exhaust thread scheduling
 or ORC cycle-collector interleavings.
 
 The ownership scenarios, lifetime suite, and appender-state cleanup regression
-exercise the new ownership contracts. Allocator reports remain for subsequent
+exercise the new ownership contracts. The known allocator issue remains
-work.
+unresolved, with its failing scenarios temporarily disabled by default.
 
 The standalone `ownership.nim` regression suite passed AddressSanitizer and
 LeakSanitizer with `--mm:orc -d:useMalloc`. An additional worker-thread build found

tests/run_tsan.sh

@@ -5,6 +5,16 @@ binary=${1:?Expected the ThreadSanitizer test executable}
 writer_binary=${2:?Expected the writer lifecycle test executable}
 result=0
 for scenario in independent service service-lifetime service-reconfigure custom-state formatter shared-state-lifetime factory-state collector formatter-lifetime timestamp allocator; do
+  # These scenarios expose Nim 2.2.10's default-allocator race independently
+  # of logging ownership. Keep them available while the runtime fix is deferred.
+  case "$scenario" in
+    factory-state|allocator)
+      if [[ ${NSL_TEST_RUNTIME_ALLOCATOR:-0} != 1 ]]; then
+        echo "SKIP: $scenario (known Nim allocator race; set NSL_TEST_RUNTIME_ALLOCATOR=1 to enable)"
+        continue
+      fi
+      ;;
+  esac
   echo "ThreadSanitizer scenario: $scenario"
   if TSAN_OPTIONS=halt_on_error=1:exitcode=66 timeout 30s "$binary" "$scenario"; then
     echo "PASS: $scenario"